ci macos-x86_64: Upgrade to the macos-13 image #3387

kazarmy · 2024-10-20T05:17:19Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've updated the documentation with the relevant information (if needed)

Detailed description

The GitHub macos-12 image is in the process of being removed so this pr replaces it with the macos-13 image.

Test plan (required)

The replacement is appropriate.

Closing issues

...

kazarmy · 2024-10-20T05:46:21Z

Redness is unrelated

karliss

In my opinion macos-13 would be better.

Both for running the build on oldest reasonably available mac, and to avoid the "large" GHA instances.

This reverts commit 51d23de.

kazarmy · 2024-10-20T06:14:32Z

In my opinion macos-13 would be better.

Both for running the build on oldest reasonably available mac, and to avoid the "large" GHA instances.

I agree 78a9998

karliss · 2024-10-20T06:46:58Z

As for the hdiutil failures I guess it's worth trying the second workaround described here.

actions/runner-images#7522 (comment)

kazarmy · 2024-10-20T07:27:13Z

Ok 29931e7

…4-large

karliss · 2024-10-20T10:02:04Z

That's separate problem, but the M1 macos failure can be fixed by adding

                -DPython3_FIND_STRATEGY="LOCATION" \
                -DPython_FIND_STRATEGY="LOCATION" \

This reverts commit bc45892.

This reverts commit bb66970.

This reverts commit d6c6552.

This reverts commit 4b33f82.

This reverts commit 29931e7.

…ckage"" This reverts commit 0dda13b.

This reverts commit 0fe73a1.

This reverts commit 3f7ee23.

kazarmy · 2024-10-20T15:06:49Z

That's separate problem, but the M1 macos failure can be fixed by adding
                -DPython3_FIND_STRATEGY="LOCATION" \
                -DPython_FIND_STRATEGY="LOCATION" \

There's no guarantee that the first Python version found won't be 3.13.

Btw, the macos-14-arm64 runner image swung from 20241007.259 (Python 3.12) to 20241014.301 (Python 3.13) and back to 20241007.259 (Python 3.12) in the course of a few hours.

karliss · 2024-10-20T15:40:01Z

There's no guarantee that the first Python version found won't be 3.13.

I would hope that having explicit "Python_ROOT_DIR" hint has higher priority in the search order compared to whatever default search folders are.

karliss

<

.github/workflows/ci.yml

wargio · 2024-10-21T03:01:07Z

WTF. why libquickjs| Compiler for C supports arguments /experimental:c11atomics: NO is not supported? is required for qjs

wargio · 2024-10-21T08:41:53Z

@kazarmy i merged my fix on jsdec repo (with also a test for msvc 2019)

wargio · 2024-10-21T08:42:36Z

.github/workflows/ci.yml

+        # https://github.com/actions/runner-images/issues/7522#issuecomment-1556766641
+        echo killing XProtectBehaviorService; sudo pkill -9 XProtect >/dev/null || true;
+        echo waiting for XProtectBehaviorService kill; while pgrep XProtect; do sleep 3; done;
+        brew install kadwanev/brew/retry


maybe move this eariler since you are installing a dependency.

ok 0d5b7db

wargio · 2024-10-21T08:44:02Z

.github/workflows/ci.yml

+        echo killing XProtectBehaviorService; sudo pkill -9 XProtect >/dev/null || true;
+        echo waiting for XProtectBehaviorService kill; while pgrep XProtect; do sleep 3; done;
+        brew install kadwanev/brew/retry
+        retry 'rm -rf ../jsdec ../libswift ../rz_libyara ../rz-silhouette; make package'


why this is done on some plugins and not all the plugins? is this related to some redness where they do not compile? if yes, add a comment explaining why this is here.

it's due to (https://github.com/rizinorg/cutter/actions/runs/11425970615/job/31788307472#step:7:9706):

the other plugins were rimrafed because the build is so slow and it would have taken too long to check the plugins one-by-one

if yes, add a comment explaining why this is here.

ok 97b93a5

.github/workflows/ci.yml

This reverts commit ee2fa79.

This reverts commit 84e12d6.

ci macos-x86_64: Upgrade to the macos-14-large image

51d23de

karliss requested changes Oct 20, 2024

View reviewed changes

kazarmy added 2 commits October 20, 2024 14:11

Revert "ci macos-x86_64: Upgrade to the macos-14-large image"

1e69ddd

This reverts commit 51d23de.

ci macos-x86_64: Upgrade to the macos-13 image

78a9998

kazarmy changed the title ~~ci macos-x86_64: Upgrade to the macos-14-large image~~ ci macos-x86_64: Upgrade to the macos-13 image Oct 20, 2024

karliss approved these changes Oct 20, 2024

View reviewed changes

mac ci: Kill XProtectBehaviorService before making package

29931e7

kazarmy marked this pull request as draft October 20, 2024 08:52

kazarmy added 4 commits October 20, 2024 16:58

Try adding -debug to hdiutil

4b33f82

Merge branch 'dev' of https://github.com/rizinorg/cutter into macos-1…

53612bb

…4-large

Add hdiutil-debug.sh

d6c6552

Use absolute path for hdiutil-debug.sh

bb66970

kazarmy added 13 commits October 20, 2024 18:23

Use /bin/bash

bc45892

Revert "Use /bin/bash"

77563ba

This reverts commit bc45892.

Revert "Use absolute path for hdiutil-debug.sh"

064d10c

This reverts commit bb66970.

Revert "Add hdiutil-debug.sh"

c20f015

This reverts commit d6c6552.

Revert "Try adding -debug to hdiutil"

6a4aeaf

This reverts commit 4b33f82.

Retry make package until it works

e374667

Revert "mac ci: Kill XProtectBehaviorService before making package"

0dda13b

This reverts commit 29931e7.

Do rm -rf

a66bb3b

Revert "Revert "mac ci: Kill XProtectBehaviorService before making pa…

0212980

…ckage"" This reverts commit 0dda13b.

Set exclusive upper bound for Python version

0fe73a1

Revert "Set exclusive upper bound for Python version"

8229db4

This reverts commit 0fe73a1.

Uninstall Python 3.13

3f7ee23

Revert "Uninstall Python 3.13"

bfc6052

This reverts commit 3f7ee23.

kazarmy marked this pull request as ready for review October 20, 2024 15:07

karliss requested changes Oct 20, 2024

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

Add comment regarding XProtectBehaviorService kill

e78c29c

kazarmy force-pushed the macos-14-large branch from db06aa7 to e78c29c Compare October 20, 2024 16:20

karliss approved these changes Oct 20, 2024

View reviewed changes

wargio approved these changes Oct 21, 2024

View reviewed changes

wargio mentioned this pull request Oct 21, 2024

Disable atomics when msvc does not support c11atomics rizinorg/jsdec#60

Merged

wargio reviewed Oct 21, 2024

View reviewed changes

kazarmy added 6 commits October 21, 2024 17:42

Move kadwanev/brew/retry install to "homebrew dependencies" section

0d5b7db

Add rimraf comment

97b93a5

Try using a Python venv

84e12d6

Have separate macos "py dependencies" section

ee2fa79

Use Python_FIND_VIRTUALENV=ONLY

26044c7

Use Python3_FIND_VIRTUALENV=ONLY

0885d9b

kazarmy marked this pull request as draft October 21, 2024 11:23

kazarmy marked this pull request as ready for review October 21, 2024 11:35

karliss requested changes Oct 21, 2024

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

kazarmy added 3 commits October 21, 2024 21:12

Use Python3_FIND_STRATEGY="LOCATION" instead

3a1ff3a

Revert "Have separate macos "py dependencies" section"

7cf9e2a

This reverts commit ee2fa79.

Revert "Try using a Python venv"

8f4f89f

This reverts commit 84e12d6.

karliss approved these changes Oct 21, 2024

View reviewed changes

kazarmy merged commit 22094c2 into rizinorg:dev Oct 21, 2024
14 checks passed

kazarmy mentioned this pull request Oct 22, 2024

ci: Reinstate macos-meson-clang-tests build on macos-13 rizinorg/rizin#4682

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci macos-x86_64: Upgrade to the macos-13 image #3387

ci macos-x86_64: Upgrade to the macos-13 image #3387

kazarmy commented Oct 20, 2024 •

edited

Loading

kazarmy commented Oct 20, 2024

karliss left a comment •

edited

Loading

kazarmy commented Oct 20, 2024 •

edited

Loading

karliss commented Oct 20, 2024 •

edited

Loading

kazarmy commented Oct 20, 2024

karliss commented Oct 20, 2024

kazarmy commented Oct 20, 2024

karliss commented Oct 20, 2024

karliss left a comment

wargio commented Oct 21, 2024

wargio commented Oct 21, 2024

wargio Oct 21, 2024

kazarmy Oct 21, 2024

wargio Oct 21, 2024

kazarmy Oct 21, 2024

kazarmy Oct 21, 2024

ci macos-x86_64: Upgrade to the macos-13 image #3387

ci macos-x86_64: Upgrade to the macos-13 image #3387

Conversation

kazarmy commented Oct 20, 2024 • edited Loading

kazarmy commented Oct 20, 2024

karliss left a comment • edited Loading

Choose a reason for hiding this comment

kazarmy commented Oct 20, 2024 • edited Loading

karliss commented Oct 20, 2024 • edited Loading

kazarmy commented Oct 20, 2024

karliss commented Oct 20, 2024

kazarmy commented Oct 20, 2024

karliss commented Oct 20, 2024

karliss left a comment

Choose a reason for hiding this comment

wargio commented Oct 21, 2024

wargio commented Oct 21, 2024

wargio Oct 21, 2024

Choose a reason for hiding this comment

kazarmy Oct 21, 2024

Choose a reason for hiding this comment

wargio Oct 21, 2024

Choose a reason for hiding this comment

kazarmy Oct 21, 2024

Choose a reason for hiding this comment

kazarmy Oct 21, 2024

Choose a reason for hiding this comment

kazarmy commented Oct 20, 2024 •

edited

Loading

karliss left a comment •

edited

Loading

kazarmy commented Oct 20, 2024 •

edited

Loading

karliss commented Oct 20, 2024 •

edited

Loading